Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAO address for Claim contract is called after TimelockController is deployed #77

Merged
merged 2 commits into from
Apr 12, 2024
Merged

DAO address for Claim contract is called after TimelockController is deployed #77

merged 2 commits into from
Apr 12, 2024

Conversation

matjazv
Copy link
Contributor

@matjazv matjazv commented Apr 11, 2024

What was the problem?

This PR resolves #70.

How was it solved?

Deployment scripts were modified:

  • From Claim deployment script setDAOAddress function call was removed.
  • setDAOAddress function call was added to the Governor deployment script.

How was it tested?

Manually tested.

@matjazv matjazv self-assigned this Apr 11, 2024
Phanco
Phanco approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@Phanco Phanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@matjazv
Copy link
Contributor Author

matjazv commented Apr 11, 2024 •
edited
Loading

Calling recoverLSK function inside Claim contract is still secure, because there's unit test where daoAddress is zero and transaction fails.

@matjazv matjazv merged commit 7140ba3 into main Apr 12, 2024
3 checks passed
@matjazv matjazv deleted the 70-dao-address-claim-contract branch April 12, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasKendziorra AndreasKendziorra AndreasKendziorra approved these changes

@Phanco Phanco Phanco approved these changes

Assignees

@matjazv matjazv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setDAOAddress for Claim contract should be called after TimelockController is deployed
3 participants
@matjazv @Phanco @AndreasKendziorra