Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up recursive and dead state in redux #5338

Merged
merged 5 commits into from
Sep 29, 2023
Merged

Clean up recursive and dead state in redux #5338

merged 5 commits into from
Sep 29, 2023

Conversation

oskarleonard
Copy link
Contributor

What was the problem?

This PR resolves #5336

How was it solved?

Added a hook which clean up badly stored redux state if found

How was it tested?

  1. Buy manually adding circular object to mainChainNetwork in settings state.
  2. By manually adding a blockchainApplications application which doesnt exists in networks nor customNetworks
  3. Page refresh the application
  4. Expected: Should remove circular object in step 1, should remove dead application in step 2

@oskarleonard oskarleonard self-assigned this Sep 25, 2023
@ManuGowda ManuGowda merged commit 51a6a1f into release/3.0.0 Sep 29, 2023
3 checks passed
@ManuGowda ManuGowda deleted the 5336-clean-up-redux-persited-state branch September 29, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eniolam1000752 eniolam1000752 eniolam1000752 approved these changes

@ManuGowda ManuGowda ManuGowda approved these changes

Assignees

@oskarleonard oskarleonard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oskarleonard @ManuGowda @eniolam1000752