Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix account balance calculation #5356

Merged
merged 8 commits into from
Oct 4, 2023
Merged

Bugfix account balance calculation #5356

merged 8 commits into from
Oct 4, 2023

Conversation

ManuGowda
Copy link
Contributor

@ManuGowda ManuGowda commented Oct 2, 2023 •
edited
Loading

What was the problem?

This PR resolves #5349, #5347

How was it solved?

  • Fix account balance and usable balance bug by check against available balance and amount to spend including fee
  • Fix transaction incoming and outgoing arrow

How was it tested?

  • Check wallet for incoming and outgoing transaction
  • Send entire balance (considering fees)

@ManuGowda ManuGowda self-assigned this Oct 2, 2023
eniolam1000752
eniolam1000752 previously approved these changes Oct 2, 2023
View reviewed changes
@ManuGowda ManuGowda merged commit c1a6139 into release/3.0.0 Oct 4, 2023
3 checks passed
@ManuGowda ManuGowda deleted the 5349-bugfix-account-balance-calculation branch October 4, 2023 09:13
@ManuGowda ManuGowda restored the 5349-bugfix-account-balance-calculation branch November 17, 2023 17:35
@ManuGowda ManuGowda deleted the 5349-bugfix-account-balance-calculation branch November 28, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eniolam1000752 eniolam1000752 eniolam1000752 approved these changes

@ikem-legend ikem-legend ikem-legend approved these changes

Assignees

@ManuGowda ManuGowda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ManuGowda @ikem-legend @eniolam1000752