Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent auto update of generator table #5422

Merged
merged 6 commits into from
Nov 9, 2023
Merged

Prevent auto update of generator table #5422

merged 6 commits into from
Nov 9, 2023

Conversation

oskarleonard
Copy link
Contributor

What was the problem?

This PR resolves #5399

How was it solved?

Replacing refetchInterval on generator table with ui button to enable refreshes of this table.

How was it tested?

  1. Go to http://localhost:8080/#/validators
  2. Sort by commission
  3. Wait 20 sec
  4. Expected: List should not have been update
  5. Click Refresh
  6. Expected: List is now updated

@oskarleonard oskarleonard requested review from ikem-legend and eniolam1000752 and removed request for ikem-legend November 8, 2023 14:22
@oskarleonard oskarleonard self-assigned this Nov 8, 2023
eniolam1000752
eniolam1000752 suggested changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@eniolam1000752 eniolam1000752 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I get this error when I navigate to other tabs likeValidators and Sanctioned tab.
image
  • Placement seems disturbing as it distorts the view of the other tabs
image

src/theme/QueryTable/QueryTable.js Outdated Show resolved Hide resolved
@ikem-legend ikem-legend self-requested a review November 9, 2023 08:39
@eniolam1000752 eniolam1000752 merged commit 735c8ca into release/3.0.0 Nov 9, 2023
3 checks passed
@eniolam1000752 eniolam1000752 deleted the 5399-prevent-auto-update-of-validator-table branch November 9, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eniolam1000752 eniolam1000752 eniolam1000752 approved these changes

@ikem-legend ikem-legend ikem-legend approved these changes

Assignees

@oskarleonard oskarleonard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oskarleonard @ikem-legend @eniolam1000752