Resolved toaster display on unrelated accounts #5461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…448-claims-rewards-toaster-ux
ManuGowda
suggested changes
Nov 17, 2023
Good catch. I've fixed it for application switch as well as network switch |
ManuGowda
previously approved these changes
Nov 17, 2023
| @@ -65,7 +71,10 @@ export function useCurrentAccount() { | |||
| } | |||
| } | |||
| } | |||
| // Remove toast between account switches | |||
| toast.dismiss(); | |||
There was a problem hiding this comment.
This is the only real change in this file? Others are formatting? Just want to know because i will get merge conflict on this file if this PR is merged before my PR
There was a problem hiding this comment.
Yeah, they're formatting changes and some of them are enforced by our pre commit hooks
src/modules/blockchainApplication/manage/hooks/useCurrentApplication.js
Outdated
Show resolved
Hide resolved
src/modules/network/components/networkSwitcherDropdown/NetworkSwitcherDropdown.js
Outdated
Show resolved
Hide resolved
…448-claims-rewards-toaster-ux
oskarleonard
approved these changes
Nov 17, 2023
ManuGowda
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #5448
How was it solved?
How was it tested?