Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account name should be saved on enter key press #5514

Merged
merged 8 commits into from
Dec 4, 2023

Conversation

eniolam1000752
Copy link
Contributor

@eniolam1000752 eniolam1000752 commented Dec 1, 2023

What was the problem?

This PR resolves #5501, #5490, #5516

How was it solved?

  • Add type button to the cancel button.
  • Introduce bookmark button to muti-signature status modal.
  • Fix unit test

How was it tested?

How to test change account name fix

  • Navigate to account details modal
  • Try changing the name of the account and hit the enter key
  • The account name should be saved

How to test bookmarking on muti-signature transaction status

  • Initiate a send token transaction to a non-bookmarked address from a multi-signature account.
  • Collect all signatures and send the finialise the transaction.
  • It should be seen that on the status page, the add to bookmark button is shown.

@eniolam1000752 eniolam1000752 self-assigned this Dec 1, 2023
@ManuGowda ManuGowda self-requested a review December 1, 2023 14:20
@ManuGowda ManuGowda merged commit 29d8249 into development Dec 4, 2023
6 checks passed
@ManuGowda ManuGowda deleted the 5501-save-account-name-on-enter branch December 4, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save account name on enter
2 participants