Add private key import feature #5595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -12,7 +12,7 @@ const BackupRecoveryPhraseFlow = () => { | |||
| const [passphrase, setPassphrase] = useState(''); | |||
|
|
|||
| const onEnterPasswordSuccess = ({ recoveryPhrase }) => { | |||
| setPassphrase(recoveryPhrase); | |||
| setPassphrase(recoveryPhrase || ''); | |||
There was a problem hiding this comment.
shouldn't we just don't call the fn if !recoveryPhrase ?
There was a problem hiding this comment.
if (recoveryPhrase) setPassphrase(recoveryPhrase) might be a good option in this case since passphrase is '' by default.
src/modules/account/components/ImportPrivateKeyForm/ImportPrivateKeyForm.js
Outdated
Show resolved
Hide resolved
src/modules/account/components/ImportPrivateKeyForm/ImportPrivateKeyForm.js
Outdated
Show resolved
Hide resolved
clemente-xyz
approved these changes
Jul 19, 2024
ikem-legend
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #5593
How was it solved?
Backport implementation done from Klayr at klayrHQ/klayr-desktop@v3.0.3...v3.0.6
How was it tested?
Manually tested