Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Create signBLS, verifyBLS, createAggSig, verifyAggSig and verifyWeightedAggSig function #6484

Merged
merged 14 commits into from
Jun 25, 2021
Merged

Create signBLS, verifyBLS, createAggSig, verifyAggSig and verifyWeightedAggSig function #6484

merged 14 commits into from
Jun 25, 2021

Conversation

nazarhussain
Copy link
Contributor

@nazarhussain nazarhussain commented Jun 21, 2021 •
edited
Loading

What was the problem?

This PR resolves #6471, #6472

How was it solved?

  • Added required functions to be export from lisk-cryptography package.

How was it tested?

  • Added unit tests

@nazarhussain nazarhussain self-assigned this Jun 21, 2021
@nazarhussain nazarhussain linked an issue Jun 21, 2021 that may be closed by this pull request
Create createAggSig, verifyAggSig and verifyWeightedAggSig function #6472
Closed
@nazarhussain nazarhussain marked this pull request as ready for review June 22, 2021 14:39
@nazarhussain nazarhussain requested a review from shuse2 June 22, 2021 14:40
@nazarhussain nazarhussain changed the title Create createAggSig, verifyAggSig and verifyWeightedAggSig function - Closes #6472 Create signBLS, verifyBLS, createAggSig, verifyAggSig and verifyWeightedAggSig function - Closes #6472 Jun 22, 2021
@nazarhussain nazarhussain changed the title Create signBLS, verifyBLS, createAggSig, verifyAggSig and verifyWeightedAggSig function - Closes #6472 Create signBLS, verifyBLS, createAggSig, verifyAggSig and verifyWeightedAggSig function - Closes #6471, #6472 Jun 22, 2021
Base automatically changed from 6469-bls-integration to development June 22, 2021 15:58
@shuse2 shuse2 requested a review from ishantiw June 22, 2021 15:58
shuse2
shuse2 suggested changes Jun 24, 2021
View reviewed changes
Copy link
Collaborator

@shuse2 shuse2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just minor requiests

elements/lisk-cryptography/src/bls.ts Outdated Show resolved Hide resolved
elements/lisk-cryptography/src/bls.ts Outdated Show resolved Hide resolved
elements/lisk-cryptography/src/utils.ts Outdated Show resolved Hide resolved
@nazarhussain nazarhussain requested a review from shuse2 June 24, 2021 13:27
@nazarhussain
Copy link
Contributor Author

@shuse2 Fixed the writeBit to mutate the buffer in place. Also added a few tests cases for writeBit and readBit

ishantiw
ishantiw approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

elements/lisk-cryptography/test/bls.spec.ts
@@ -0,0 +1,163 @@
/* eslint-disable camelcase */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the eth specs files contains keys which are not camelcase. So have to disable it for all the file.

@shuse2 shuse2 merged commit 1f445c6 into development Jun 25, 2021
@shuse2 shuse2 deleted the 6472-bls-functions branch June 25, 2021 11:46
@sitetester sitetester changed the title Create signBLS, verifyBLS, createAggSig, verifyAggSig and verifyWeightedAggSig function - Closes #6471, #6472 Create signBLS, verifyBLS, createAggSig, verifyAggSig and verifyWeightedAggSig function Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shuse2 shuse2 shuse2 approved these changes

@ishantiw ishantiw ishantiw approved these changes

Assignees

@nazarhussain nazarhussain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create createAggSig, verifyAggSig and verifyWeightedAggSig function Create signBLS and verifyBLS functions
3 participants
@nazarhussain @shuse2 @ishantiw