Change unfortunate char code in string example #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnathan
approved these changes
Dec 5, 2023
|
Awkward and ironic, given the character point used ( א, the first Hebrew letter of the alef-bet ). |
|
f*. thank you
|
|
https://www.compart.com/en/unicode/U+05D0 looks like somehow the Alef / Aleph range starts at the unfortunate number. Strange business... |
|
thanks for the quick merge :)
I took a look through the blame when I first noticed it, looks like that example was added in 2007, before the cookbook was on GH: 39914b6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number 1488, used in the strings page as an example character code, is often used as a covert symbol by nazi groups (source). I thought it best to change it to something innocuous, since it's a bad look regardless of the original intention behind the example.