[QUESTION] How does "sortBy": "most-used" work ?

[Zixim]

Question

I've set "sortBy": "most-used", for all of the sections on the dash, but none of the items inside of the sections are changing positions.
Does something else need to be set for sorting by most-used ?

Category

Configuration

Please tick the boxes

• You are using a supported version of Dashy (check the first two digits of the version number)
• You've checked that this question hasn't already been raised
• You've checked the docs and troubleshooting guide
• You agree to the code of conduct

[liss-bot]

If you're enjoying Dashy, consider dropping us a ⭐
_{🤖 I'm a bot, and this message was automated}

[hypatia1]

I also have this problem.

[liss-bot]

This issue has gone 6 weeks without an update. To keep the ticket open, please indicate that it is still relevant in a comment below. Otherwise it will be closed in 5 working days.

[Zixim]

This is still relevant.

[Lissy93]

Heya @Zixim
Sorry for the delay...

So when section[n].displayData.sortBy: most-used is enabled for a given section, each time you click an item, a click count will be stored in local storage (using key MOST_USED). Then items are sorted based on this value.

Here's the code for the sorting:

dashy/src/components/LinkItems/Section.vue

Lines 222 to 228 in 0319b8b

	/* Sorts items by most used to least used, based on click-count */
	sortByMostUsed(items) {
	const usageCount = JSON.parse(localStorage.getItem(localStorageKeys.MOST_USED) || '{}');
	const gmu = (item) => usageCount[item.id] || 0;
	items.reverse().sort((a, b) => (gmu(a) < gmu(b) ? 1 : -1));
	return items;
	},

And here's the code for the setting:

dashy/src/mixins/ItemMixin.js

Lines 215 to 222 in 0319b8b

	/* Used for smart-sort when sorting items by most used apps */
	incrementMostUsedCount(itemId) {
	const mostUsed = JSON.parse(localStorage.getItem(localStorageKeys.MOST_USED) || '{}');
	let counter = mostUsed[itemId] || 0;
	counter += 1;
	mostUsed[itemId] = counter;
	localStorage.setItem(localStorageKeys.MOST_USED, JSON.stringify(mostUsed));
	},

Since data is only stored client-side, so if you open Dashy on a new device or browser, then usage counters won't be carried over, hence the order may vary between sessions.

[Zixim]

@Lissy93 thanks for your clarification. It just doesn't seem to be working at all.

Here's what is stored in Local Storage :

This for a Dashy instance that has been set to sortby most-used for all sections for many weeks, i.e. :

  - name: Online media
    icon: fas fa-book
    displayData:
      sortBy: most-used
      rows: 1
      cols: 3
      collapsed: true
      hideForGuests: false
    items:
      .....

Something must be wrong somewhere ?

[Lissy93]

Oh yeah, you're right - looks like the itemId is undefined when it gets passed to that function. It should have been this.item.id instead of this.id. I've opened a PR to fix this in #1123 :)