Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Translation not used (remember-me) #127

Closed
EVOTk opened this issue Aug 6, 2021 · 4 comments
Closed

[BUG] Translation not used (remember-me) #127

EVOTk opened this issue Aug 6, 2021 · 4 comments
Assignees
@Lissy93
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working

Comments

@EVOTk
Copy link
Contributor

EVOTk commented Aug 6, 2021

Hello,
On the login screen, the "remember me" drop-down menu does not display the translation but always the English version.

In French version :
2021-08-07 01_46_45-Dashy

In German version :
2021-08-07 01_47_39-Dashy

However the translation is present, for example in: dashy/src/assets/locales/de.json
2021-08-07 01_47_57-dashy_de json at master · Lissy93_dashy

Thx again.
@EVOTk EVOTk added the 🐛 Bug [ISSUE] Ticket describing something that isn't working label Aug 6, 2021
Lissy93 added a commit that referenced this issue Aug 7, 2021
@Lissy93
🐛 Re: #127 - Fixes translations not being picked up in dropdown
9f33bac
@Lissy93 Lissy93 mentioned this issue Aug 7, 2021
Merged
6 tasks
@Lissy93
Copy link
Owner

Lissy93 commented Aug 7, 2021

Oh yeah, this was a bug, thanks for raising it. It seemed like that because this text was in a dynamic component, the data was being set before the language files were loaded in, so was always falling back to English. Fixed in #129 :)

@Lissy93 Lissy93 closed this as completed in 8668621 Aug 7, 2021
@EVOTk
Copy link
Contributor Author

EVOTk commented Aug 7, 2021

Thank you very much for your responsiveness, as always!

@EVOTk
Copy link
Contributor Author

EVOTk commented Aug 15, 2021

Hello,
the basic "never" text seems to ignore the translation :(

2021-08-15 02_20_09-Window
2021-08-15 02_20_16-Window

@Lissy93 Lissy93 reopened this Aug 15, 2021
Lissy93 added a commit that referenced this issue Aug 15, 2021
@Lissy93
🐛 Re: #127 - Fixes translation not loading
f034349
@Lissy93 Lissy93 mentioned this issue Aug 15, 2021
Merged
6 tasks
@EVOTk
Copy link
Contributor Author

EVOTk commented Aug 15, 2021

Thank you very much !

asterling8516 pushed a commit to asterling8516/dashy that referenced this issue Nov 23, 2023
@walkxcode
🍱 Adds Elastic (Lissy93#127)
0eebfe7 
Closes Lissy93#127

Signed-off-by: Bjorn Lammers <walkxnl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lissy93 Lissy93

Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Lissy93 @EVOTk