Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE_REQUEST] MaterialDesignIcons #139

Closed
ExXxtr3me opened this issue Aug 9, 2021 · 5 comments
Closed

[FEATURE_REQUEST] MaterialDesignIcons #139

ExXxtr3me opened this issue Aug 9, 2021 · 5 comments
Assignees
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change

Comments

@ExXxtr3me
Copy link

Would it be possible to support also MaterialDesignIcons (https://materialdesignicons.com) ?
Fontawesome is missing many icons for apps like Plex, Nginx, Jallyfin, Sonarr, Radarr aso.

@ExXxtr3me ExXxtr3me added the 🦄 Feature Request [ISSUE] Suggestion for new feature, update or change label Aug 9, 2021
@ExXxtr3me ExXxtr3me changed the title [FEATURE_REQUEST] [FEATURE_REQUEST] MaterialDesignIcons Aug 9, 2021
@Lissy93
Copy link
Owner

Lissy93 commented Aug 9, 2021

Sure, this is a good idea. I was actually thinking about implementing support for Simple Icons, as they are light-weight SVGs with logos from a wide range of apps and services.

I will look into Material Design Icons, but their package is 200kb, and they don't seem to have an API, so I will have to see if there is method of implementing that won't have an impact on performance. Will take a look either this evening or tomorrow evening and get back to you here :)

@ExXxtr3me
Copy link
Author

Awesome, thank you very much for considering it. Don´t know if it helps, but homeassistant supports them, maybe there is some way for you to look how they do it?

SimpleIcons look also nice. 👍

Lissy93 added a commit that referenced this issue Aug 9, 2021
Re: #139 - Implementation for Material-Design-Icons
@Lissy93
Copy link
Owner

Lissy93 commented Aug 9, 2021

Hey @ExXxtr3me
I've implemented support for your Material Design Icons in #141 - which when merged, will be released in V1.5.7, which you can pull down from DH with the :latest tag.

You can use it by setting icon to mid-[name-of-icon], e.g. icon: mdi-alien

Enjoy :)

@Lissy93 Lissy93 closed this as completed in ff1249b Aug 9, 2021
@Lissy93
Copy link
Owner

Lissy93 commented Aug 9, 2021

Merged.
I forgot to say, that the icon package is only loaded in if one or more of your items are using mdi icons. That's the same as font-awesome. So if you combine both FA and MDI icons, you might experience a hit in performance, so it's best to choose one or the other.
Btw, if you're enjoying the app, please consider Staring the repo. I think it helps others find it :)

@ExXxtr3me
Copy link
Author

Wow, that was fast. Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change
Projects
None yet
Development

No branches or pull requests

2 participants