Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION] dockerfile command may need run yarn start not yarn build-and-start? #1543

Open
4 tasks done
lee88688 opened this issue Apr 22, 2024 · 4 comments
Open
4 tasks done
Labels
🤷‍♂️ Question [ISSUE] Further information is requested

Comments

@lee88688
Copy link

Question

in Dockerfile, this has run yarn build

RUN yarn build --mode production

why is there need another build in start command in yarn build-and-start
CMD [ "yarn", "build-and-start" ]

I override command using yarn start which works too, so there is some feature I discover?

Category

Setup and Deployment

Please tick the boxes

@lee88688 lee88688 added the 🤷‍♂️ Question [ISSUE] Further information is requested label Apr 22, 2024
@CrazyWolf13

This comment was marked as off-topic.

@Lissy93
Copy link
Owner

Lissy93 commented Apr 22, 2024

I think you're right @lee88688 - thanks for the suggestion.
I'll do a bit more testing, but if all that passes, this will be released later this week, in 3.0.1.

@Lissy93
Copy link
Owner

Lissy93 commented Apr 29, 2024

Yup, you were right. Much better without the second build!
Merged 1bbb91b into #1542 and released to 3.0.1

@CrazyWolf13
Copy link
Collaborator

Hi @lee88688

I temporarly had to revert the changes, as issues like this #1559 would arise, as the container is not watching for changes on the files.

Until lissy has time to properly look into this, we will keep this change reverted.

But if you don't repull the :latest tag, that should not change anything for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤷‍♂️ Question [ISSUE] Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants