Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE_REQUEST] Hide Settings from Guests and Specific users #1552

Closed
G-S322 opened this issue Apr 24, 2024 · 5 comments
Closed

[FEATURE_REQUEST] Hide Settings from Guests and Specific users #1552

G-S322 opened this issue Apr 24, 2024 · 5 comments
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change

Comments

@G-S322
Copy link

G-S322 commented Apr 24, 2024

Is your feature request related to a problem? If so, please describe.

I don't like how users and guests have access to the menu can download the config file from the settings menu, which also contains the hashed password...

Describe the solution you'd like

I would like to have the option to disable the settings menu for guests and/or specific users completely so that this just acts as a dashboard/ Landing page for links.

I was thinking something like
hideSettingsForGuests: true
and
hideMenu: true
for users under the auth section.

Priority

Medium (Would be very useful)

Is this something you would be keen to implement

None

@G-S322 G-S322 added the 🦄 Feature Request [ISSUE] Suggestion for new feature, update or change label Apr 24, 2024
@liss-bot
Copy link
Collaborator

If you're enjoying Dashy, consider dropping us a ⭐
🤖 I'm a bot, and this message was automated

@rxunique
Copy link

+1

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Apr 26, 2024
@Lissy93
Copy link
Owner

Lissy93 commented Apr 28, 2024

Actually, this sounds like something which should be implemented by default.
If basic auth is enabled, and the user is not logged in, they shouldn't be able to write any changes.

Thoughts?

@rxunique
Copy link

should be implemented by default

Do you mean there is already implementation? Or thinking its a good idea to be default?

If basic auth is enabled, and the user is not logged in

In my mind, I was hoping add an option to appConfig.hideComponents . currently hideSettings only collapsed the setting

maybe an option disableSettings to globally stop non-admin to edit and basically view only

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Apr 28, 2024
@Lissy93
Copy link
Owner

Lissy93 commented Apr 28, 2024

maybe an option disableSettings to globally stop non-admin to edit and basically view only

Thanks @rxunique - Done!

I figured, if you've setup basic auth, and have guest access enabled- you wouldn't want guests to be able to edit configuration (otherwise there's not much point to the auth, beyond roles).

So instead of adding an extra option to disable edits from guests, it's now (since V 3.0.1) disabled by default. And so logging in is required to make changes, if auth is enabled.

If you need anything else modifying around this, let me know below, and I'll reopen.

@Lissy93 Lissy93 closed this as completed Apr 28, 2024
@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change
Projects
None yet
Development

No branches or pull requests

4 participants