-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEEDBACK] Widgets: DateTime and Weather #402
Comments
Thanks for raising the non-capitalized weather info, I'll get that fixed :) |
So with the time zone place names, it's a bit more complicated. I'm currently doing it like this: I get the time zone, either from what you've specified under getTimeZone() {
if (this.options.timeZone) return this.options.timeZone;
return Intl.DateTimeFormat().resolvedOptions().timeZone;
}, which returns something like: Then, to get the city name, I'm just using the time zone name, like: getCity(timeZone) {
return timeZone.split('/')[1].replaceAll('_', ' ');
}, The problem is, that there is no way to natively determine a time zone from an arbitrary city, like San Antonio. I did look into using a package like kevinroberts/city-timezones, but that would involve either deploying the API and making a network request, or adding 1MB into the bundle size. Both seem a bit over-kill for the simple task. I guess another option would be to let the user specify a time zone, as well as an arbitrary display name for city. You can also set Anyway, let me know your thoughts, or if you have any other suggestions about a non-complicated implementation |
I'd personally like to be able to specify a timezone and then define any other specific value Something like |
Cool, okay so that's the option I'll go for :) |
Sure, thank you, I'll add a fix to the current branch :) |
Forgot to say, but all of the above issues have now been fixed, merged and released in #425 - V 1.9.8 :)
|
For DateTime widget, can we change the name of city?
For example, although I'm using the
America/New_York
time zone, I do not live in New York. I would like to put the city I live in, but it doesn't have a formal TZ name. Same withAmerica/Chicago
, but I would like to be following the time for people living in San Antonio since they have the same time zone. I don't want to change them all; I just want the option (ex. my "Tokyo" tz is fine as-is).Weather
The daily forecast terms are inconsistently cased. The words
visibility
,wind
, andclouds
are not title cased.Also, thank you so much for the creation of widgets. With this, Dashy has reached basically all my criteria for the perfect dash 😄
The text was updated successfully, but these errors were encountered: