[QUESTION] RSS widget improvement

[wtld]

Question

I am working on adding two options to RSS widget (I plan a PR):

1. Optionally don't display item descriptions (only titles)
2. The ability to display the both date and time, not just the date

But my question is:

Should I change the following fragment in the original widget code:

axios.get(this.endpoint)
  .then((response) => {
    this.processData(response.data);
  })
  .catch((error) => {
    this.error('Unable to RSS feed', error);
  })
  .finally(() => {
    this.finishLoading();
  });

to this one:

this.makeRequest(this.endpoint).then(this.processData);

Seems much cleaner for me :) I am new to Dashy, maybe makeRequest method was added after RSS Widget was created?

Category

Widgets

Please tick the boxes

• You are using a supported version of Dashy (check the first two digits of the version number)
• You've checked that this question hasn't already been raised
• You've checked the docs and troubleshooting guide
• You agree to the code of conduct

[Lissy93]

Yeah, you're right, it should be that :)
I added makeRequest after I'd already created several of the widgets, and it looks like I forgot to refactor that

[liss-bot]

The fix for this issue has now been released in 2.0.9 ✨

If you haven't done so already, please update your instance to 2.0.9 or later. See 2.0.9 for full info.

Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project.

[Zovix]

I am working on adding two options to RSS widget (I plan a PR):

1. Optionally don't display item descriptions (only titles)

Was this added as a feature? I was looking for the option in the docs and didn't see it.