-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] title in browser tab doesnt changes #645
Comments
The fix for this issue has now been released in 2.0.9 ✨ If you haven't done so already, please update your instance to Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project. |
I am having this exact issue on 2.1.1, using docker to deploy. Tested in multiple browsers.
|
Same issue here, also running 2.1.1 |
1 similar comment
Same issue here, also running 2.1.1 |
Same issue here on 2.1.1. This recompiles the assets and the title lines up with what I expect. The downside is that the yarn build adds 30+ seconds to the boot time of the dashboard. |
I'll try this when I get a chance. Do you need to run that command one time and then revert back? |
If you can find a way to retain the filesystem that the dashy service is using then in theory that might work. You could add a entrypoint script and manage it that way? It wasn't a big enough deal to spend any more time on ¯_(ツ)_/¯ Here is what the compose service looks like when it works if that helps. For now, I've just commented out the dashboard:
container_name: dashboard
image: lissy93/dashy
command: ["yarn", "build-and-start"]
volumes:
- ./conf/dashy/my-config.yml:/app/public/conf.yml
- ./conf/dashy/item-icons:/app/public/item-icons
ports:
- 4000:80
environment:
- NODE_ENV=production
restart: unless-stopped
healthcheck:
test: ['CMD', 'node', '/app/services/healthcheck']
interval: 1m30s
timeout: 10s
retries: 3
start_period: 40s |
Environment
Self-Hosted (Docker)
Version
2.0.8
Describe the problem
pageinfo.title does not changes title in browser tab.
This was tested on multiple systems (windows 10/ centOS 7) and different browsers (chrome/edge/IE).
Steps to reproduce:
Additional info
Please tick the boxes
The text was updated successfully, but these errors were encountered: