Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Adding Guest translations #1029

Merged
merged 1 commit into from
Jan 1, 2023
Merged

🌐 Adding Guest translations #1029

merged 1 commit into from
Jan 1, 2023

Conversation

Dylan-Bs
Copy link
Contributor

@Dylan-Bs Dylan-Bs commented Dec 30, 2022 •
edited by pull-request-badge bot
Loading

Dylan-Bs 🌐 Language Update Medium Dylan-Bs /master → Lissy93/dashy Commits: 1 | Files Changed: 3 | Additions: 15

Category: Code style update

Overview

Improving Internationalization process. Adding guest variables in locales "en" and "fr"

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

Feel free to correct me, it's my first PR! 👶

Thanks for reviewing,
Dylan-Bs

@netlify
Copy link

netlify bot commented Dec 30, 2022 •
edited
Loading

✅ Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit db017c0
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/63af19f305d2f900099d72b3
😎 Deploy Preview https://deploy-preview-1029--dashy-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented Dec 30, 2022

Changes preview:

Legend:

👀 Review pull request on Viezly

Lissy93
Lissy93 approved these changes Jan 1, 2023
View reviewed changes
Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks @Dylan-Bs
And happy new year :)

@Lissy93 Lissy93 merged commit f4f2c5f into Lissy93:master Jan 1, 2023
@Lissy93 Lissy93 added the 🌐 Language [PR] Adds a new language translation label Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lissy93 Lissy93 Lissy93 approved these changes

Assignees
No one assigned
Labels
🌐 Language [PR] Adds a new language translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dylan-Bs @Lissy93