Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HealthChecks linting errors #1048

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Fix HealthChecks linting errors #1048

merged 1 commit into from
Jan 25, 2023

Conversation

m42e
Copy link
Contributor

@m42e m42e commented Jan 8, 2023 •
edited by pull-request-badge bot
Loading

m42e Quick m42e /healthcheck-fix-errors → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 1 Unchecked Tasks 🚫 Merge Conflicts

Category: Bugfix

Overview
Fixed linter errors introduces with my last healthchecks changes. My apologies.

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@m42e m42e requested a review from Lissy93 as a code owner January 8, 2023 18:15
@netlify
Copy link

netlify bot commented Jan 8, 2023 •
edited
Loading

✅ Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit c50773e
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/63ced50a1d979500091f0887
😎 Deploy Preview https://deploy-preview-1048--dashy-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented Jan 8, 2023 •
edited
Loading

Changes preview:

Legend:

👀 Review pull request on Viezly

@liss-bot liss-bot added the 🚫 Merge Conflicts [PR] Submitted code needs rebasing label Jan 23, 2023
@m42e
Copy link
Contributor Author

m42e commented Jan 24, 2023

Merge Conflicts have been resolved.

Lissy93
Lissy93 approved these changes Jan 25, 2023
View reviewed changes
Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙌

@Lissy93 Lissy93 merged commit adf56fa into Lissy93:master Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lissy93 Lissy93 Lissy93 approved these changes

Assignees
No one assigned
Labels
🚫 Merge Conflicts [PR] Submitted code needs rebasing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m42e @Lissy93 @liss-bot