Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed filtering by productId in cve-vulnerabilities widget #1075

Merged
merged 2 commits into from
Jan 21, 2023

Conversation

albcp
Copy link
Contributor

@albcp albcp commented Jan 21, 2023

albcp Quick albcp /master → Lissy93/dashy Commits: 2 | Files Changed: 2 | Additions: 0 Label Unchecked Tasks

Category: Bugfix and Documentation

Overview
The cve-vulnerabilities widget has been updated to include a filter by productId in the endpoint. The necessary logic was already present in the code, but it was not being applied to the endpoint. In addition, the productId values listed in the documentation were corrected as they were pointing to incorrect products. The example provided has also been updated to ensure that the default configuration returns some CVEs.

Code Quality Checklist (Please complete)

  • [ x] All changes are backwards compatible
  • [ x] All lint checks and tests are passing
  • [ x] There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@albcp albcp requested a review from Lissy93 as a code owner January 21, 2023 12:39
@netlify
Copy link

netlify bot commented Jan 21, 2023

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 1ba01ba
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/63cbdd18b38a4b0008470ead
😎 Deploy Preview https://deploy-preview-1075--dashy-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented Jan 21, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@Lissy93 Lissy93 merged commit b388adc into Lissy93:master Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants