Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial commit of the proxmox lists widget #1210

Merged
merged 1 commit into from
Jun 4, 2023
Merged

initial commit of the proxmox lists widget #1210

merged 1 commit into from
Jun 4, 2023

Conversation

alayham
Copy link
Contributor

@alayham alayham commented Jun 3, 2023 •
edited by pull-request-badge bot
Loading

alayham Medium alayham /proxmox-lists → Lissy93/dashy Commits: 1 | Files Changed: 3 | Additions: 216 Label Powered by Pull Request Badge

Category: Feature

Overview: Added a widget to list nodes, VMs, and containers in a proxmox cluster.

Code Quality Checklist (Please complete)

  • [Y] All changes are backwards compatible
  • [Y] All lint checks and tests are passing
  • [Y] There are no (new) build warnings or errors
  • [N] Bumps version, if new feature added

@alayham alayham requested a review from Lissy93 as a code owner June 3, 2023 17:42
@netlify
Copy link

netlify bot commented Jun 3, 2023 •
edited
Loading

✅ Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit b7d7927
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/647b7b7b3d69dd0008aa403a
😎 Deploy Preview https://deploy-preview-1210--dashy-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented Jun 3, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

Lissy93
Lissy93 approved these changes Jun 3, 2023
View reviewed changes
Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)
You ready for merge?

@alayham
Copy link
Contributor Author

alayham commented Jun 4, 2023

Yes. thanks.

@Lissy93 Lissy93 merged commit f1d3547 into Lissy93:master Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lissy93 Lissy93 Lissy93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alayham @Lissy93