Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit of the custom search widget #1212

Merged
merged 1 commit into from
Jun 4, 2023

Conversation

alayham
Copy link
Contributor

@alayham alayham commented Jun 4, 2023

alayham Medium alayham /custom-search → Lissy93/dashy Commits: 1 | Files Changed: 3 | Additions: 126 Label Powered by Pull Request Badge

Category: Feature

Overview
A new widget that allows web search using multiple user-defined search engines and other websites.

Screenshot
image

Code Quality Checklist

  • [Y] All changes are backwards compatible
  • [Y] All lint checks and tests are passing
  • [Y] There are no (new) build warnings or errors
  • [N] Bumps version, if new feature added

@alayham alayham requested a review from Lissy93 as a code owner June 4, 2023 17:18
@netlify
Copy link

netlify bot commented Jun 4, 2023

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit e1d4adb
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/647cc75cb6ce8a0008edbbce
😎 Deploy Preview https://deploy-preview-1212--dashy-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented Jun 4, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

},
methods: {
search(engine) {
if (engine !== undefined && this.query !== '') {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can probably just be shortened to

if (engine && this.query) { ... }

@Lissy93 Lissy93 merged commit 2324755 into Lissy93:master Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants