Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new widget for RescueTime #1278

Merged
merged 4 commits into from
Aug 13, 2023
Merged

Add new widget for RescueTime #1278

merged 4 commits into from
Aug 13, 2023

Conversation

wozboz
Copy link
Contributor

@wozboz wozboz commented Aug 10, 2023

wozboz ✨ Feature Medium wozboz /master → Lissy93/dashy Commits: 4 | Files Changed: 4 | Additions: 144 Powered by Pull Request Badge

Thank you for contributing to Dashy! So that your PR can be handled effectively, please populate the following fields (delete sections that are not applicable)

Category:

One of: Feature

Overview

Added a widget for the time tracking app "RescueTime". The widget shows how much time you have spent on each category (e.g. Business, Programming, ...)

Screenshot (if applicable)

Code Quality Checklist (Please complete)

  • [ x ] All changes are backwards compatible
  • [ x ] All lint checks and tests are passing
  • [ x ] There are no (new) build warnings or errors

@wozboz wozboz requested a review from Lissy93 as a code owner August 10, 2023 13:55
@netlify
Copy link

netlify bot commented Aug 10, 2023

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit c45e058
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/64d8d83d7da6b80008615adc
😎 Deploy Preview https://deploy-preview-1278--dashy-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@viezly
Copy link

viezly bot commented Aug 10, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great :)

docs/widgets.md Outdated
@@ -39,6 +39,7 @@ Dashy has support for displaying dynamic content in the form of widgets. There a
- [Mvg Departure](#mvg-departure)
- [Mvg Connection](#mvg-connection)
- [Custom search](#custom-search)
- [Rescuetime overview] (#rescuetime-overview)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a space between the name and link which makes it not render quite right.

- - [Rescuetime overview] (#rescuetime-overview)
                         ^
                         ╰ Just remove this ;)
+ - [Rescuetime overview](#rescuetime-overview)                       

},
calculateTimeCategories(timeArray) {
const results = {};
// console.log(timeArray.rows[0]);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to remove this?
And the // import axios from 'axios'; on L21 ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep... looked over this about 10 times, somehow missed it. Thanks for removing it :)

@Lissy93 Lissy93 added the ✨ New Feature [PR] Contains implementation of a new feature label Aug 13, 2023
@Lissy93 Lissy93 merged commit d4126ba into Lissy93:master Aug 13, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ New Feature [PR] Contains implementation of a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants