Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sorting by vmid in the proxmox widget #1460

Merged
merged 2 commits into from
Feb 24, 2024

Conversation

alayham
Copy link
Contributor

@alayham alayham commented Feb 6, 2024

alayham Quick alayham /fix-proxmox-widger-sorting → Lissy93/dashy Commits: 2 | Files Changed: 2 | Additions: 5 Powered by Pull Request Badge

Category:

Bugfix

Overview

The Proxmox lists widget treats vmids as strings when sorting, they should be numbers.

Code Quality Checklist (Please complete)

  • All changes are backwards compatible.
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented (No new configs)
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance (No new deps)
  • Bumps version, if new feature added (No new features)

@alayham alayham requested a review from Lissy93 as a code owner February 6, 2024 15:58
Copy link

netlify bot commented Feb 6, 2024

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 4a570ed
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/65c36e0aac902a000890053f
😎 Deploy Preview https://deploy-preview-1460--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Feb 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashy ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2024 11:49am

@alayham
Copy link
Contributor Author

alayham commented Feb 7, 2024

** Note: This PR is part of the Episode 8 of my devlab series.
https://youtu.be/6H9j2OFr69U
I will write an article about it as well for medium https://medium.com/@al-saleh

The text and all the mentioned links are in this article:https://medium.com/@al-saleh/building-a-node-js-development-container-with-ansible-f916a89241e6?sk=3...
Read writing from Al Saleh on Medium. Software architect, writing code since 1997, 4 published books. Every day, Al Saleh and thousands of other voices read, write, and share important stories on Medium.

@Lissy93 Lissy93 merged commit 006eb6c into Lissy93:master Feb 24, 2024
9 checks passed
@liss-bot
Copy link
Collaborator

liss-bot commented Mar 3, 2024

The fix for this issue has now been released in 2.1.2 ✨

If you haven't done so already, please update your instance to 2.1.2 or later. See 2.1.2 for full info.

Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants