Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] 🐳 Adds back Docker arm/v7 support #1492

Merged
merged 5 commits into from
Mar 4, 2024
Merged

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Mar 4, 2024

🐛 Fix Medium Lissy93 /FIX/docker-arm-v7 → Lissy93/dashy Commits: 5 | Files Changed: 4 | Additions: 18 Unchecked Tasks Powered by Pull Request Badge

Category: Bugfix

Overview
After version 2.1.2 was released, which included a major update on many dependencies, plus upgrading the version of Node used, the docker-build-publish.yml workflow started failing. This was narrowed down to be caused by it hanging when it got to the ARM/v7 architecture build, and as such that was temporarily removed so that build would succeed.

This PR adds back ARM/v7 support, while keeping all other architectures working.

More details here: docker/build-push-action#1071 (comment)

Issue Number N/A

New Vars N/A

Screenshot N/A
Not a screenshot, but see workflow run: 8140614115

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@Lissy93 Lissy93 requested a review from CrazyWolf13 March 4, 2024 13:21
Copy link

vercel bot commented Mar 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashy ❌ Failed (Inspect) Mar 4, 2024 3:14pm

Copy link

netlify bot commented Mar 4, 2024

👷 Deploy Preview for dashy-dev processing.

Name Link
🔨 Latest commit 427e46a
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/65e5e5256ff20900084c06ad

@Lissy93 Lissy93 added the 🦋 Bug Fix [PR] Code includes bug fixes label Mar 4, 2024
@Lissy93 Lissy93 merged commit aef7f78 into master Mar 4, 2024
8 checks passed
@Lissy93 Lissy93 deleted the FIX/docker-arm-v7 branch March 4, 2024 15:16
Copy link
Collaborator

@CrazyWolf13 CrazyWolf13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
Looks good to me :)
As long as we only build the img with node 18, I don't really see a problem, however long term we should probably create an issue at the respective place, if not already reported, so Github or Docker can fix it on their end.

@Lissy93
Copy link
Owner Author

Lissy93 commented Mar 4, 2024

I think it's a known issue, with the the NPM install hanging in newer versions of Node, when emulating other architectures through QEMU. As I saw several other tickets of people facing the same thing.
nodejs/docker-node#1798
qemu-project/qemu#1729

@CrazyWolf13 CrazyWolf13 mentioned this pull request Mar 7, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦋 Bug Fix [PR] Code includes bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants