-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] 🐳 Adds back Docker arm/v7 support #1492
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
👷 Deploy Preview for dashy-dev processing.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Looks good to me :)
As long as we only build the img with node 18, I don't really see a problem, however long term we should probably create an issue at the respective place, if not already reported, so Github or Docker can fix it on their end.
I think it's a known issue, with the the NPM install hanging in newer versions of Node, when emulating other architectures through QEMU. As I saw several other tickets of people facing the same thing. |
Category: Bugfix
Overview
After version 2.1.2 was released, which included a major update on many dependencies, plus upgrading the version of Node used, the
docker-build-publish.yml
workflow started failing. This was narrowed down to be caused by it hanging when it got to the ARM/v7 architecture build, and as such that was temporarily removed so that build would succeed.This PR adds back ARM/v7 support, while keeping all other architectures working.
More details here: docker/build-push-action#1071 (comment)
Issue Number N/A
New Vars N/A
Screenshot N/A
Not a screenshot, but see workflow run: 8140614115
Code Quality Checklist (Please complete)