Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Improved Search #175

Merged
merged 10 commits into from
Aug 22, 2021
Merged

[FEATURE] Improved Search #175

merged 10 commits into from
Aug 22, 2021

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Aug 22, 2021

Lissy93 /FEATURE/improved-search → Lissy93/dashy Commits: 10 | Files Changed: 21 | Additions: 235 Powered by Pull Request Badge

Category: Feature

Overview

  • Improves and refactors existing search algorithm
  • Adds option for Tags, enabling user to search by them
  • Writes some docs about Searching & Shortcuts

Issue Number N/A

New Vars

  • item[n].tags - string[] Optional - An array of tags for a specific item, which can be used to find said item

Screenshot N/A

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@netlify
Copy link

netlify bot commented Aug 22, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: 490e8ed

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/6122819279cd28000727216b

😎 Browse the preview: https://deploy-preview-175--dashy-dev.netlify.app/

@viezly
Copy link

viezly bot commented Aug 22, 2021

This pull request is split into 4 parts for easier review.
👀 Review pull request on Viezly

Changed files are located in these folders:

  • .github
  • /
  • docs
  • src

|| filterHelper(provider, searchTerm)
|| filterHelper(description, searchTerm)
|| filterHelper(tags, searchTerm)
|| filterHelper(getDomainFromUrl(url), searchTerm);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W014: Misleading line break before '||'; readers may interpret this as an expression boundary.
(at-me in a reply with help or ignore)

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using AirBnB lint styleguide means that this is the approach enforced by ESLint

@Lissy93 Lissy93 self-assigned this Aug 22, 2021
@lgtm-com
Copy link

lgtm-com bot commented Aug 22, 2021

This pull request fixes 4 alerts when merging b0384d8 into 12b1143 - view on LGTM.com

fixed alerts:

  • 4 for Duplicate character in character class

@lgtm-com
Copy link

lgtm-com bot commented Aug 22, 2021

This pull request fixes 4 alerts when merging 490e8ed into 12b1143 - view on LGTM.com

fixed alerts:

  • 4 for Duplicate character in character class

@Lissy93 Lissy93 merged commit 04726e9 into master Aug 22, 2021
@Lissy93 Lissy93 deleted the FEATURE/improved-search branch September 4, 2021 20:43
asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant