Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apikey for Weather Forecast #1829

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dintho
Copy link

@dintho dintho commented Mar 11, 2025

dintho Quick dintho /patch-2 → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 1 Label Unchecked Tasks Powered by Pull Request Badge

Category:

Bugfix

Overview

The Weather Forecast widget does not read in from env for the API key in the same way the weather app does

Issue Number (if applicable) #00

#1828 : created bug to attach to PR

New Vars (if applicable)

slight adjustment of the apikey constant to hopefully allow it to read in the API key from an env var

Screenshot (if applicable)

If you've introduced any significant UI changes, please include a screenshot

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • (If significant change) Bumps version in package.json

Hopefully adding in the ability to read APIkey from env var
@dintho dintho requested a review from Lissy93 as a code owner March 11, 2025 00:43
Copy link

netlify bot commented Mar 11, 2025

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit bd50528
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/67cf871d10b1690008e87b46
😎 Deploy Preview https://deploy-preview-1829--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant