-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Option for Ping-Only Status Checks #233
Conversation
✔️ Deploy Preview for dashy-dev ready! 🔨 Explore the source changes: 56d4b44 🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/61453b53e19b9c0007e0497a 😎 Browse the preview: https://deploy-preview-233--dashy-dev.netlify.app |
Hi Lissy93! Thank you for contributing to Dashy! ✨ When making changes to the documentation, be sure to double check that:
You're making changes to the main server entry point. Please test the app thoroughly, as any misconfigurations here may cause the app to stop functioning. When updating dependencies, take a moment to verify that there are not security issues associated with any added or modified packages. If adding a new dependency, ensure that it is totally necessary, and check the packages size is not too large, as this will increase overall bundle size. Don't forget to verify they the config validator script responds correctly to your new attribute.
|
This pull request is split into 4 parts for easier review. Changed files are located in these folders:
|
Hmm, so it turns out that net-ping requires Python to work, and I do not want to add this to the Docker container, since it adds additional weight. I need to either find a cross-platform method of pinging an endpoint, or figure out how to sort the net-ping node-gyp issue. I really should have looked into that before building this feature out 🤦 |
Actually including: The Docker image would be a lot more light-weight if I re-wrote the server-side stuff in Go instead of Node. And in doing so, the ping functionality would be easy. But since that'd be a big task, it will have to wait till I have some spare time. |
Sorry for missunderstanding ,so what should we do ? run in consol ? |
No, because this feature was never merged (it's closed). So it's not possible to use it. I mentioned this in your other thread. |
you said i can somehow to ping no ? |
I said it's been discussed before, and isn't possible in dashy. You'll need to write a script yourself. But I'm 90% sure you can get status checking working by following the docs. Feel like this is goning round in circles now. |
OK Thanks a lot i will try .. |
Signed-off-by: Bjorn Lammers <walkxnl@gmail.com>
Closes Lissy93#233 Signed-off-by: Bjorn Lammers <walkxnl@gmail.com>
Category: Feature
Overview
Several users have faced issues either with certain services having failing status checks, or being unable to check the status of web services that don't render any content (such as game servers, mail servers, file servers, etc). This is because the default status check option works by sending an empty GET request to the URL, which obviously cannot work for services that are not designed to accept these requests.
This PR introduces a new option,
statusCheckPingOnly
. If this is set to true for a given service, then just a traditional ping will be sent to that IP address.Issue Number: #181 (Kinda sort of related)
New Vars
statusCheckPingOnly
(boolean
Optional) If enabled, instead of sending a HTTP request, this option will use a simple ping to your appScreenshot N/A
Code Quality Checklist (Please complete)