Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Additional languages, bug fix, and quick refactor #234

Merged
merged 21 commits into from
Sep 18, 2021

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Sep 18, 2021

Large Lissy93 /FEATURE/more-languages → Lissy93/dashy Commits: 21 | Files Changed: 29 | Additions: 1157 🐛 Fix 🚚 Refactor 💄 Stylistic Changes 🌟 Showcase Addition Powered by Pull Request Badge

Category: Bugfix, Refactoring, Documentation, Languages

Overview

Issue Number #232

New Vars N/A

Screenshot
Tooltip Fix:
image

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@Lissy93 Lissy93 added 🦋 Bug Fix [PR] Code includes bug fixes 💯 Showcase [ISSUE][PR] Adding a new demo or screenshot to the showcase 🚚 Refactor [PR] Non-feature code-related updates and refactoring 💄 Stylistic Changes [PR] UI or CSS style changes 🌐 Language [PR] Adds a new language translation labels Sep 18, 2021
@netlify
Copy link

netlify bot commented Sep 18, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: 15c2ffc

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/614622d9086a820007d67e1b

😎 Browse the preview: https://deploy-preview-234--dashy-dev.netlify.app/

@liss-bot
Copy link
Collaborator

Hi Lissy93! Thank you for contributing to Dashy! ✨

When making changes to the documentation, be sure to double check that:

  • Link and images URLs properly resolve
  • Your spelling and grammar is correct
  • Any markdown formatting is valid

You're making changes to the main server entry point. Please test the app thoroughly, as any misconfigurations here may cause the app to stop functioning.

Thank you for adding your dashboard to the showcase! 🌟

Thank you for contributing to Dashy's translations 💖


I'm a bot, and this is an automated comment 🤖

@viezly
Copy link

viezly bot commented Sep 18, 2021

This pull request is split into 5 parts for easier review.
👀 Review pull request on Viezly

Changed files are located in these folders:

  • /
  • docs
  • src
  • src/assets/locales
  • src/styles

@Lissy93 Lissy93 merged commit c1a18ab into master Sep 18, 2021
@Lissy93 Lissy93 deleted the FEATURE/more-languages branch September 18, 2021 18:18
asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Signed-off-by: Bjorn Lammers <walkxnl@gmail.com>
asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Closes Lissy93#234

Signed-off-by: Bjorn Lammers <walkxnl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦋 Bug Fix [PR] Code includes bug fixes 🌐 Language [PR] Adds a new language translation 🚚 Refactor [PR] Non-feature code-related updates and refactoring 💯 Showcase [ISSUE][PR] Adding a new demo or screenshot to the showcase 💄 Stylistic Changes [PR] UI or CSS style changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants