Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARCH] Implement VueX State Management #271

Merged
merged 21 commits into from
Oct 10, 2021
Merged

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Oct 9, 2021

Medium Lissy93 /ARCH/implement-vuex-state → Lissy93/dashy Commits: 21 | Files Changed: 37 | Additions: 192 🏗️ Architecture SyntaxError: missing ) after argument list%20after%20argument%20list/red)

Category: Refactoring

Overview
Vuex is a state management pattern + library for Vue apps, like Dashy. It will serve as a centralized data store, and has rules to ensure that the state can only be mutated in a predictable fashion. To learn more, see the VueX Docs.
Implementing this will lead to a more ogranised code base long term, but will also make building out the new UI editor significantly easier to do in a clean and reliable way.

Issue Number N/A

New Vars N/A

Screenshot N/A

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@netlify
Copy link

netlify bot commented Oct 9, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: e1b812c

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/616313aa260b3a00088ce4c9

😎 Browse the preview: https://deploy-preview-271--dashy-dev.netlify.app

@liss-bot
Copy link
Collaborator

liss-bot commented Oct 9, 2021

Hi Lissy93! Thank you for contributing to Dashy! ✨

When updating dependencies, take a moment to verify that there are not security issues associated with any added or modified packages. If adding a new dependency, ensure that it is totally necessary, and check the packages size is not too large, as this will increase overall bundle size.


I'm a bot, and this is an automated comment 🤖

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Oct 9, 2021
@viezly
Copy link

viezly bot commented Oct 9, 2021

This pull request is split into 6 parts for easier review.
👀 Review pull request on Viezly

Changed files are located in these folders:

  • .github
  • /
  • src

@Lissy93 Lissy93 changed the title [ARCH] Implement VueX State Management WIP: [ARCH] Implement VueX State Management Oct 9, 2021
@Lissy93
Copy link
Owner Author

Lissy93 commented Oct 9, 2021

/rebase

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Oct 9, 2021
Repository owner deleted a comment from liss-bot Oct 9, 2021
@liss-bot liss-bot added the 🚫 Merge Conflicts [PR] Submitted code needs rebasing label Oct 10, 2021
@liss-bot
Copy link
Collaborator

yarn.lock changes

Click to toggle table visibility
Name Status Previous Current
vuex ADDED - 3.6.2

@Lissy93 Lissy93 added the 🏗️ Architectural Changes [PR] Updates to application architecture, data flow or structure label Oct 10, 2021
@Lissy93
Copy link
Owner Author

Lissy93 commented Oct 10, 2021

This is quite a large PR, and includes significant architectural changes. It must be thoroughly tested before merging, to prevent unintentionally breaking anything. There aren't really any new user facing features here, but this PR lays the ground for the next big task - the new UI config editor.

@Lissy93 Lissy93 removed the 🚫 Merge Conflicts [PR] Submitted code needs rebasing label Oct 10, 2021
@liss-bot
Copy link
Collaborator

Size Change: +3.68 kB (0%)

Total Size: 1.9 MB

Filename Size Change
./dist/js/chunk-********.db9652fc.js 0 B -2.05 kB (removed) 🏆
./dist/js/chunk-********.087feb1d.js 0 B -591 B (removed) 🏆
./dist/js/chunk-********.ff8ef00c.js 0 B -437 B (removed) 🏆
./dist/js/chunk-vendors.********.js 1.77 MB +3.41 kB (0%)
./dist/js/dashy.********.js 97.1 kB +313 B (0%)
./dist/precache-********.fd0ebd127b7242b860b7866cde435170.js 0 B -3.46 kB (removed) 🏆
./dist/js/chunk-********.6b00cc8e.js 406 B +406 B (new file) 🆕
./dist/js/chunk-********.ac3decfd.js 2.05 kB +2.05 kB (new file) 🆕
./dist/js/chunk-********.38fd5bbc.js 591 B +591 B (new file) 🆕
./dist/precache-********.d935cfbaac0cbfa595124ae235427b6b.js 3.46 kB +3.46 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./dist/css/chunk-********.a64c098d.css 348 B 0 B
./dist/css/chunk-********.f5d4b402.css 899 B 0 B
./dist/css/chunk-********.974ecc90.css 0 B -98 B (removed) 🏆
./dist/css/chunk-vendors.********.css 847 B 0 B
./dist/css/dashy.********.css 20.7 kB -5 B (0%)
./dist/default.html 2.61 kB 0 B
./dist/index.html 1.09 kB -1 B (0%)
./dist/service-worker.js 619 B -2 B (0%)
./dist/css/chunk-********.6fea770a.css 98 B +98 B (new file) 🆕

compressed-size-action

Repository owner deleted a comment from liss-bot Oct 10, 2021
Repository owner deleted a comment from liss-bot Oct 10, 2021
Repository owner deleted a comment from liss-bot Oct 10, 2021
@Lissy93 Lissy93 changed the title WIP: [ARCH] Implement VueX State Management [ARCH] Implement VueX State Management Oct 10, 2021
Repository owner deleted a comment from liss-bot Oct 10, 2021
Repository owner deleted a comment from liss-bot Oct 10, 2021
Repository owner deleted a comment from liss-bot Oct 10, 2021
Repository owner deleted a comment from liss-bot Oct 10, 2021
Repository owner deleted a comment from liss-bot Oct 10, 2021
@Lissy93 Lissy93 merged commit 7f555ee into master Oct 10, 2021
@liss-bot
Copy link
Collaborator

The fix for this issue has now been released in Dashy 1.9.0 ✨

If you haven't done so already, please update your instance to 1.9.0 or later. See Dashy 1.9.0 for full info.

Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project.

@Lissy93 Lissy93 deleted the ARCH/implement-vuex-state branch October 31, 2021 21:04
asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏗️ Architectural Changes [PR] Updates to application architecture, data flow or structure 🟧 PR - Large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants