Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG-FIX] Status check tooltip visibility, Re: #39 #40

Merged
merged 2 commits into from
Jun 19, 2021

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Jun 19, 2021

Please check the type of change your PR introduces:

  • Bugfix

Issue Number (if applicable): #39

Briefly outline your changes:
The tooltips for status indicators were not visible in some themes. Fixed it by adding custom CSS variable so that themes can target the element correctly, and also added a class name so that the Material theme did not set display: none to the status indicator tooltip.

Before submitting, please ensure that:

  • Must be backwards compatible
  • All lint checks and tests must pass
  • If a new option in the the config file is added, it needs to be added into the schema, and documented in the configuring guide
  • If a new dependency is required, it must be essential, and it must be thoroughly checked out for security or efficiency issues

Fixes styling issue causing status check tooltip to not be visible in certain themes
@vercel
Copy link

vercel bot commented Jun 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/alicia/dashy/z7KfJrKh2GhUa8mkmv2DeuseqdDY
✅ Preview: https://dashy-git-bug-fix39-statuscheck-visibility-alicia.vercel.app

@netlify
Copy link

netlify bot commented Jun 19, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: a3a84e5

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/60cdee0c4ae32b00085211d4

😎 Browse the preview: https://deploy-preview-40--dashy-dev.netlify.app/

@Lissy93 Lissy93 merged commit 3d37ec6 into master Jun 19, 2021
@Lissy93 Lissy93 deleted the bug-fix_39-statuscheck-visibility branch June 19, 2021 13:19
asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] statuscheck not display correctly on the Material / Material-dark and High-contrast-light themes
1 participant