Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] Use local font assets #60

Merged
merged 4 commits into from
Jul 3, 2021
Merged

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Jun 24, 2021

Overview

  • Added Truetype font files locally in ./public/fonts/
  • Updated typography.scss, removing Google Fonts CDN, and instead referencing local font assets
  • Added some typography docs, and credited the authors in ./docs/theming.md

Category: Refactor

Issue Number: #58

New Vars: N/A

Screenshot: N/A

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance

Full credit to the typographers behind each of the fonts. Specifically: Matt McInerney, Christian Robertson, Haley Fiege, Peter Hull, Cyreal and the legendary Vernon Adams, RIP
@netlify
Copy link

netlify bot commented Jun 24, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: 8e5f076

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/60e0babbc98275000700bcf9

😎 Browse the preview: https://deploy-preview-60--dashy-dev.netlify.app/

@Lissy93 Lissy93 merged commit 87c592c into master Jul 3, 2021
@Lissy93 Lissy93 deleted the REFACTOR_Use-local-fonts branch July 3, 2021 19:36
asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant