Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Optionally allow StatPing widget to filter on group #714

Merged
merged 1 commit into from
Jun 8, 2022
Merged

✨ Optionally allow StatPing widget to filter on group #714

merged 1 commit into from
Jun 8, 2022

Conversation

marekful
Copy link
Contributor

@marekful marekful commented Jun 8, 2022 •
edited by pull-request-badge bot
Loading

marekful ✨ Feature Medium marekful /FEATURE/StatPing-widget-group-filter-and-compact-view → Lissy93/dashy Commits: 1 | Files Changed: 2 | Additions: 43 Unchecked Tasks

... and to display in a more compact view.

  • Add widget option: groupId. StatPing services are filtered for the given group.
  • Add widget options: showChart and showInfo. Initially hide the chart and info summary.
  • Add buttons to show/hide chart and info sections.
  • Update widget documentation.

Category:

Feature

Overview

Minor enhancements to the StatPing widget

Screenshot (if applicable)

Screenshot 2022-06-08 at 20 29 24

Screenshot 2022-06-08 at 20 31 04

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@marekful
✨ Optionally allow the widget to filter on StatPing Group and to disp…
2d6c499 
…lay in a more compact view.

* Add widget option: `groupId`. StatPing services are filtered for the given group.
* Add widget options: `showChart` and `showInfo`. Initially hide the chart and info summary.
* Add buttons to show/hide chart and info sections.
* Update widget documentation.
@marekful marekful requested a review from Lissy93 as a code owner June 8, 2022 19:58
@netlify
Copy link

netlify bot commented Jun 8, 2022 •
edited
Loading

✅ Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 2d6c499
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/62a0ff67f1d8070008fb8766
😎 Deploy Preview https://deploy-preview-714--dashy-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented Jun 8, 2022

Changes preview:

Legend:

👀 Review pull request on Viezly

@marekful marekful changed the title ✨ Optionally allow the widget to filter on StatPing Group ✨ Optionally allow StatPing widget to filter on group Jun 8, 2022
@Lissy93 Lissy93 added the ✨ New Feature [PR] Contains implementation of a new feature label Jun 8, 2022
Lissy93
Lissy93 approved these changes Jun 8, 2022
View reviewed changes
Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an awesome feature!
And thanks for adding the docs too :)
Code looks all good 👍

@Lissy93 Lissy93 merged commit 9faab35 into Lissy93:master Jun 8, 2022
@marekful
Copy link
Contributor Author

Thanks for your review, @Lissy93, good points. Next time I'll try to respond faster :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lissy93 Lissy93 Lissy93 approved these changes

Assignees
No one assigned
Labels
✨ New Feature [PR] Contains implementation of a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marekful @Lissy93