Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace APOD API with new one #745

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Replace APOD API with new one #745

merged 2 commits into from
Jun 21, 2022

Conversation

k073l
Copy link

@k073l k073l commented Jun 21, 2022 •
edited by pull-request-badge bot
Loading

k073l Medium k073l /FEATURE/735_apod_update → Lissy93/dashy Commits: 2 | Files Changed: 2 | Additions: 0 Label

Category:

Bugfix/Feature

Overview

Changes APOD API URL to https://go-apod.herokuapp.com/apod from Lissy93/go-apod and fixes APOD Widget to use values returned by new API.

Issue Number (if applicable) #735

Screenshot (if applicable)

apod

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors

@k073l k073l requested a review from Lissy93 as a code owner June 21, 2022 12:23
@netlify
Copy link

netlify bot commented Jun 21, 2022 •
edited
Loading

✅ Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 45900da
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/62b1b83f7913f600087b96ba
😎 Deploy Preview https://deploy-preview-745--dashy-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented Jun 21, 2022

Changes preview:

Legend:

👀 Review pull request on Viezly

Lissy93
Lissy93 approved these changes Jun 21, 2022
View reviewed changes
Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you! 👍

@Lissy93 Lissy93 merged commit 0674ad8 into Lissy93:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lissy93 Lissy93 Lissy93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k073l @Lissy93