Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 Handle failed component load. #759

Merged
merged 1 commit into from
Jun 24, 2022
Merged

🩹 Handle failed component load. #759

merged 1 commit into from
Jun 24, 2022

Conversation

patrickheeney
Copy link

@patrickheeney patrickheeney commented Jun 24, 2022

patrickheeney Quick patrickheeney /FIX/Improve-Failed-Load → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 0 Label

Category: Bugfix

Overview
Per discussion adding some notification to the user.

Issue Number Lissy93/dashy/pull/758

New Vars N/A

Screenshot

By mounting the Blank component if there is an unknown type the user will see:
Screen Shot 2022-06-24 at 8 03 53 AM

And in the console:
Screen Shot 2022-06-24 at 8 03 57 AM

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@netlify
Copy link

netlify bot commented Jun 24, 2022

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 542a9fe
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/62b5d2abd71c110009009f8c
😎 Deploy Preview https://deploy-preview-759--dashy-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented Jun 24, 2022

Changes preview:

Legend:

👀 Review pull request on Viezly

Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@Lissy93 Lissy93 merged commit a3a26ce into Lissy93:master Jun 24, 2022
@patrickheeney patrickheeney deleted the FIX/Improve-Failed-Load branch June 24, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants