Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🩹 Ensure stat finished before startSSLServer() #760

Merged
merged 1 commit into from
Jun 24, 2022
Merged

🩹 Ensure stat finished before startSSLServer() #760

merged 1 commit into from
Jun 24, 2022

Conversation

marekful
Copy link
Contributor

@marekful marekful commented Jun 24, 2022 •
edited by pull-request-badge bot
Loading

marekful 🐛 Fix Medium marekful /FIX/start-ssl-on-slow-filesystem → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 2 Unchecked Tasks

Category:

Bugfix

Overview

The two chained stat() promises may not have finished by the time enableSSL is evaluated in case of a slow filesystem (e.g. on a Raspberry Pi where the only block device is an SD card).

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@marekful
🩹 Ensure stat finished before startSSLServer()
91d4fd5 
The two chained stat() promises may not have finished by the time
`enableSSL` is evaluated in case of a slow file system (e.g. on a
Raspberry Pi where the only block device is an SD card).
@marekful marekful requested a review from Lissy93 as a code owner June 24, 2022 19:46
@netlify
Copy link

netlify bot commented Jun 24, 2022 •
edited
Loading

✅ Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 91d4fd5
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/62b61489acbfd30008ad11f2
😎 Deploy Preview https://deploy-preview-760--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented Jun 24, 2022

Changes preview:

Legend:

👀 Review pull request on Viezly

Lissy93
Lissy93 approved these changes Jun 24, 2022
View reviewed changes
Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, thanks for fixing :)

@Lissy93 Lissy93 merged commit 51f6e30 into Lissy93:master Jun 24, 2022
@Lissy93 Lissy93 added the 🦋 Bug Fix [PR] Code includes bug fixes label Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lissy93 Lissy93 Lissy93 approved these changes

Assignees
No one assigned
Labels
🦋 Bug Fix [PR] Code includes bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marekful @Lissy93