Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 Stop status-check when Item is destroyed #767

Merged
merged 1 commit into from
Jun 26, 2022

Conversation

marekful
Copy link
Contributor

@marekful marekful commented Jun 26, 2022

marekful Quick marekful /FIX/stop-status-checks → Lissy93/dashy Commits: 1 | Files Changed: 2 | Additions: 5 Label Unchecked Tasks

Category:
Bugfix

Overview
Status-checks keep running when navigating away from a page with Items and a new interval is started in addition when navigating back to it.

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@marekful marekful requested a review from Lissy93 as a code owner June 26, 2022 17:33
@netlify
Copy link

netlify bot commented Jun 26, 2022

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 736f0e9
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/62b89868870aaf0008808f71
😎 Deploy Preview https://deploy-preview-767--dashy-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented Jun 26, 2022

Changes preview:

Legend:

👀 Review pull request on Viezly

Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@Lissy93 Lissy93 merged commit 7ab3285 into Lissy93:master Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants