Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added:Serialization/Deserialization support for float(Single) and long(Int64) type. #4

Closed
wants to merge 4 commits into from

Conversation

SONIC3D
Copy link

@SONIC3D SONIC3D commented May 4, 2013

I added serialization/deserialization support for float(Single) and long(Int64) type.
I used these types in coding Unity3D android plugin.

@HashbangGames
Copy link

Why is this not merged yet? The lack of this fix in LitJSON has bit me in the arsehole so many times! Good work Sonic! I hope they add this soon! Btw - Mr. TG wanted me to tell you that the fix has been there since 0.5 ..

@SONIC3D
Copy link
Author

SONIC3D commented Jun 21, 2014

Glad it is useful to you. =D
Mind telling me who is Mr. TG?

@lbv
Copy link
Collaborator

lbv commented Aug 15, 2014

Hello,

First of all, sorry for the long silence.

SONIC3D, thank you very much for your contributions. I haven't studied the commits carefully yet, but I see you've included things not directly related to the subject of this pull request (the MonoDevelop files). Could you please go back and create new pull requests for the things that are not directly related to the Serialization/Deserialization issue? This would greatly help me track both the code and discussions better.

Again, thanks a lot.

@SONIC3D
Copy link
Author

SONIC3D commented Aug 15, 2014

Good to hear you back!
Sure,I will recreate a clean pull request to replace that one ASAP.Maybe
several hrs later.As I can access my pc in my office.

Leonardo B notifications@github.com于2014年8月16日星期六写道:

Hello,

First of all, sorry for the long silence.

SONIC3D, thank you very much for your contributions. I haven't studied the
commits carefully yet, but I see you've included things not directly
related to the subject of this pull request (the MonoDevelop files). Could
you please go back and create new pull requests for the things that are not
directly related to the Serialization/Deserialization issue? This would
greatly help me track both the code and discussions better.

Again, thanks a lot.


Reply to this email directly or view it on GitHub
#4 (comment).

A hedgehog who can not run fast...
:)

@SONIC3D
Copy link
Author

SONIC3D commented Aug 16, 2014

I have split this one into two separate pull requests.
Please reference these 2 links for further more info:
#25
#26

This request is now closed by the request initiator.

@SONIC3D SONIC3D closed this Aug 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants