-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Team pick icon + ratings #25
Conversation
speedyman08
commented
Sep 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good, but I don't like the implications of the CSS behind it.
I've gotten it working under tailwind. Just a few issues though:
|
2023-09-12.19-33-26.mp4 |
The tooltip can now be used anywhere now. To use it, add a 'tooltip-container' class to an element, and add the 'tooltip' component as a child to it. Also, the width is not hardcoded anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot better, just nitpicks at this point
The font not automatically applying is definitely unintentional behavior so I'll look at it when I get a chance. Ideally there should be 0 CSS rules like the rest of refresh-web. |
Removing the request for review since my previous review pass still holds for now. As a side-note, apologies for the delay. Haven't been feeling well the past couple of days but things have been steadily improving, and this PR should hopefully speed up now 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some changes so it's easier to use from an HTML standpoint, and I'm now pretty happy with how this turned out. I think there's some design changes to be made (e.g. shadowing & better contrast in general) but this can be addressed later after I've played around in Figma enough.
Apologies for the long review process and the dramatic changes necessary it took to get here, but regardless, thank you for the contribution!