refactor for localhost development #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't even make an issue, just while testing localhost development, I noticed I was not able to access three paths: `/data`, `/schemas`, and `/tests`. Just so happens that those three paths coincided with physical paths, there were folders of the same name. And PHP's builtin server just would not allow the router script to control the situation, it simply refused to serve those paths. I have therefore renamed these three folders by moving them all under a single `jsondata` folder, and refactoring all the code that referenced these folders. And now, localhost development seems to work just fine on all paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't even make an issue, just while testing localhost development, I noticed I was not able to access three paths:
/data,/schemas, and/tests. Just so happens that those three paths coincided with physical paths, there were folders of the same name. And PHP's builtin server just would not allow the router script to control the situation, it simply refused to serve those paths.I have therefore renamed these three folders by moving them all under a single
jsondatafolder, and refactoring all the code that referenced these folders. And now, localhost development seems to work just fine on all paths.