-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destack v3 #103
Merged
Merged
Destack v3 #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR replaces Craft.js with a new vanilla editor. While the new editor is visually similar to the previous one it enables a few major changes to the project:
Beta Testing
The beta starter project on destack-starter-beta is updated for anyone willing to test the new version.
Tradeoffs
A major change with the new editor is that Destack no longer uses a custom JSON format to store the user generated pages and uses pure HTML instead. Besides the many benefits and significant reduction in complexity not having React based components comes with a tradeoff in flexibility. If not handle properly, more flexibility could be dangerous as uncle Ben said. For example, someone might use the editor in a user facing application not realising that there's no XSS validation by default.
Another tradeoff is that it's harder to implement state management with the vanilla editor. This is not generally a problem as HTML acts as the state but there are a few cases that state management is useful. For example, state diffs required by Undo/Redo are easier to handle in JSON files than HTML files that are plain text.
Moving forward