-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CM-1260 Implement LiveIntent Prebid User Id Module Based On The Hub #42
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side, would only recommend splitting out the shared code.
not sure about the naming of the files in /libraries, but also no good ideas.
@3link do you have a better suggestion?
@@ -1,387 +1,14 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, it's a bit unfortunate that it doesn't show the diff between this one and /libraries/liveIntentIdSystem/liveIntentIdSystem.js (treating it as a move), as that makes this a bit more difficult to review. No suggestions how to fix this though.
Hmm. maybe we can call the new module |
|
Tread carefully! This PR adds 4 linter errors (possibly disabled through directives):
|
Tread carefully! This PR adds 4 linter errors (possibly disabled through directives):
|
Tread carefully! This PR adds 4 linter errors (possibly disabled through directives):
|
Tread carefully! This PR adds 4 linter errors (possibly disabled through directives):
|
const PUBLISHER_ID = '89899'; | ||
const defaultConfigParams = { params: {publisherId: PUBLISHER_ID, fireEventDelay: 1} }; | ||
|
||
describe('LiveIntentIdHub', function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not find a test that checks for example if appId
and distributorId
are provided, only one of them will be used. Can we add it if it is really missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added here
Co-authored-by: Viktor Dreiling <34981284+3link@users.noreply.github.com>
Tread carefully! This PR adds 4 linter errors (possibly disabled through directives):
|
Tread carefully! This PR adds 4 linter errors (possibly disabled through directives):
|
Tread carefully! This PR adds 4 linter errors (possibly disabled through directives):
|
Tread carefully! This PR adds 4 linter errors (possibly disabled through directives):
|
@@ -0,0 +1,201 @@ | |||
import {UID1_EIDS} from '../uid1Eids/uid1Eids.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can drop the liveIntentId prefix from all files in libraries. They are in a folder called liveintentId anyway. So I would do:
- externalIdSystem.js
- idSystem.js
- shared.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okie
Tread carefully! This PR adds 4 linter errors (possibly disabled through directives):
|
Tread carefully! This PR adds 4 linter errors (possibly disabled through directives):
|
Tread carefully! This PR adds 8 linter errors (possibly disabled through directives):
|
Tread carefully! This PR adds 6 linter errors (possibly disabled through directives):
|
Tread carefully! This PR adds 5 linter errors (possibly disabled through directives):
|
Tread carefully! This PR adds 4 linter errors (possibly disabled through directives):
|
Tread carefully! This PR adds 4 linter errors (possibly disabled through directives):
|
CM-1260
Implement LiveIntent Prebid User Id Module Based On The Hub
Type of change
Description of change
Other information
Related PR: LiveIntent/prebid.github.io#25