Implement liveintentRtd module #45
Conversation
wi101
requested review from
nachinius,
SuperIzya,
mschuwalow,
3link and
peixunzhang
|
Tread carefully! This PR adds 3 linter warnings (possibly disabled through directives):
|
|
Tread carefully! This PR adds 3 linter warnings (possibly disabled through directives):
|
|
Tread carefully! This PR adds 3 linter warnings (possibly disabled through directives):
|
|
Tread carefully! This PR adds 3 linter warnings (possibly disabled through directives):
|
|
Tread carefully! This PR adds 3 linter warnings (possibly disabled through directives):
|
|
Tread carefully! This PR adds 3 linter warnings (possibly disabled through directives):
|
1 similar comment
|
Tread carefully! This PR adds 3 linter warnings (possibly disabled through directives):
|
|
Tread carefully! This PR adds 3 linter warnings (possibly disabled through directives):
|
| @@ -190,7 +190,7 @@ describe('LiveIntentId', function() { | |||
|
|
|||
| it('should not return a decoded identifier when the unifiedId is not present in the value', function() { | |||
| const result = liveIntentIdSubmodule.decode({ params: { fireEventDelay: 1, additionalData: 'data' } }); | |||
| expect(result).to.be.eql({}); | |||
| expect(result).to.be.eql({ 'lipb': {'params': { 'fireEventDelay': 1, 'additionalData': 'data' }} }); | |||
There was a problem hiding this comment.
It looks like the test is broken. The input should be (value, config). The test is only passing in config and it is handled as value. This inout should be ({}, { params: { fireEventDelay: 1, additionalData: 'data' } })
|
Tread carefully! This PR adds 3 linter warnings (possibly disabled through directives):
|
|
Tread carefully! This PR adds 3 linter warnings (possibly disabled through directives):
|
|
Tread carefully! This PR adds 3 linter warnings (possibly disabled through directives):
|
|
Tread carefully! This PR adds 3 linter warnings (possibly disabled through directives):
|
| @@ -469,6 +479,13 @@ describe('LiveIntentId', function() { | |||
| expect(result).to.eql({'lipb': {'lipbid': 'foo', 'nonId': 'foo', 'tdid': 'bar'}, 'tdid': {'id': 'bar', 'ext': {'rtiPartner': 'TDID', 'provider': provider}}}); | |||
| }); | |||
|
|
|||
| it('should decode the segments to a separate object when present', function() { | |||
There was a problem hiding this comment.
It will not decode segments to a separate object - as discussed in the docs PR. It will be part of the lipb id.
There was a problem hiding this comment.
good catch, I copy pasted the text, but the expectation of test is as discussed.
|
Tread carefully! This PR adds 3 linter warnings (possibly disabled through directives):
|
CM-1589
Tested in this page: https://vdreiling-lab-test.s3.us-east-1.amazonaws.com/prebid1589/liveintentRtdExample.html
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information