Implement liveintentRtd module #45
Conversation
wi101
requested review from
nachinius,
SuperIzya,
mschuwalow,
3link and
peixunzhang
|
Tread carefully! This PR adds 3 linter warnings (possibly disabled through directives):
|
|
|
||
| function onBidRequest(bidRequest, config, userConsent) { | ||
| bidRequest.bids.forEach(bid => { | ||
| const userIdSegments = { segment: bid.userId.lipbid.segments.map(id => ({ id })) } |
There was a problem hiding this comment.
Each path segment in .userId.lipbid.segments is optional. Please use optional chaining (?.)
| function onBidRequest(bidRequest, config, userConsent) { | ||
| bidRequest.bids.forEach(bid => { | ||
| const userIdSegments = { segment: bid.userId.lipbid.segments.map(id => ({ id })) } | ||
| const liSegments = [{name: 'liveintent.com', ...userIdSegments}] |
There was a problem hiding this comment.
If userIdSegments is empty or undefined, you should not add anything.
| if (bidRequest?.ortb2?.user?.data) { | ||
| bidRequest.ortb2.user.data = bidRequest.ortb2.user.data.concat(liSegments) | ||
| } else { | ||
| bidRequest.ortb2 = {...bidRequest.ortb2, ...{user: {data: liSegments}}} |
There was a problem hiding this comment.
bidRequest.ortb2 can be undefined here. Then the ... operator will fail.
| const userIdSegments = { segment: bid.userId.lipbid.segments.map(id => ({ id })) } | ||
| const liSegments = [{name: 'liveintent.com', ...userIdSegments}] | ||
| if (bidRequest?.ortb2?.user?.data) { | ||
| bidRequest.ortb2.user.data = bidRequest.ortb2.user.data.concat(liSegments) |
There was a problem hiding this comment.
Currently, you iterate over bids, but ignore them and keep concatenating the same data multiple times.
The goal is this: Enrich each bid (bid.ortb2.user.data) according to the segments known to that bid. Additionally enrich the bidRequest (bidRequest.ortb2.user.data) according to the segments known to it.
CM-1589
Tested in this page: https://vdreiling-lab-test.s3.us-east-1.amazonaws.com/prebid1589/liveintentRtdExample.html
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information