Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CM-610: Update the NPM LiveConnect module version in Prebid #6

Closed
wants to merge 12 commits into from
Closed

CM-610: Update the NPM LiveConnect module version in Prebid #6

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9a2a9d3
update with live-connect last change
wi101 Oct 21, 2022
ba9be4f
set globalVarName
wi101 Oct 26, 2022
4355d06
not use globalVarName
wi101 Oct 26, 2022
c3d78fc
Merge github.com:LiveIntent/Prebid.js into cm-610
wi101 Oct 31, 2022
6472e86
use live-connect proper version
wi101 Nov 2, 2022
24d0d59
comment
wi101 Nov 11, 2022
d558cd3
Merge github.com:LiveIntent/Prebid.js into cm-610
wi101 Nov 11, 2022
e902634
use yalc version and adjust the initializer
wi101 Nov 14, 2022
e28ed06
adjust getInitializer
wi101 Nov 14, 2022
f65b9ab
use a proper lc version
wi101 Nov 17, 2022
392e659
update with master
wi101 Dec 5, 2022
5a6f4cc
Merge github.com:LiveIntent/Prebid.js into cm-610
wi101 Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions modules/liveIntentIdSystem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import { submodule } from '../src/hook.js';
import { LiveConnect } from 'live-connect-js/esm/initializer.js';
import { gdprDataHandler, uspDataHandler } from '../src/adapterManager.js';
import { getStorageManager } from '../src/storageManager.js';
import { MinimalLiveConnect } from 'live-connect-js/esm/minimal-live-connect.js';

const MODULE_NAME = 'liveIntentId';
export const storage = getStorageManager({gvlid: null, moduleName: MODULE_NAME});
Expand Down Expand Up @@ -113,7 +112,7 @@ function initializeLiveConnect(configParams) {

// The second param is the storage object, LS & Cookie manipulation uses PBJS
// The third param is the ajax and pixel object, the ajax and pixel use PBJS
liveConnect = liveIntentIdSubmodule.getInitializer()(liveConnectConfig, storage, calls);
liveConnect = LiveConnect(liveConnectConfig, storage, calls);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After thinking more about it, I think we should leave Prebid's default behavior as is and it should use the global bus. When required, later on we can allow to configure the globalVariableName as well as whether the bus should be exposed globally or not.

if (configParams.emailHash) {
liveConnect.push({ hash: configParams.emailHash })
}
Expand All @@ -139,9 +138,6 @@ export const liveIntentIdSubmodule = {
setModuleMode(mode) {
this.moduleMode = mode
},
getInitializer() {
wi101 marked this conversation as resolved.
Show resolved Hide resolved
return this.moduleMode === 'minimal' ? MinimalLiveConnect : LiveConnect
},

/**
* decode the stored id value for passing to bid requests. Note that lipb object is a wrapper for everything, and
Expand Down
16 changes: 8 additions & 8 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@
"express": "^4.15.4",
"fun-hooks": "^0.9.9",
"just-clone": "^1.0.2",
"live-connect-js": "2.4.0"
"live-connect-js": "3.0.0-alpha.1"
},
"optionalDependencies": {
"fsevents": "^2.3.2"
Expand Down