This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
Delete distributorId before sending error #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wi101
approved these changes
Nov 11, 2022
9 tasks
mschuwalow
approved these changes
Nov 14, 2022
mschuwalow
reviewed
Nov 14, 2022
rollup-modules.config.js
Outdated
| @@ -14,7 +14,7 @@ const plugins = [ | |||
| strip() | |||
| ] | |||
|
|
|||
| const filenames = ['initializer.js', 'standard-live-connect.js', 'minimal-live-connect.js'] | |||
There was a problem hiding this comment.
I rolled back that change, we thought to use the global bus in prebid, but we decided to do that in the initializer
3link
approved these changes
Nov 14, 2022
wi101
reviewed
Nov 16, 2022
Co-authored-by: Wiem Zine El Abidine <welabidine@liveintent.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CM-631
Delete distributorId before sending error, to prevent infinite loop
Author Todo List:
Ready For Reviewstatus