Don't NPE when config option is not specified #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When some of the options are incorrectly specified, jack will throw an NPE when trying to craft a user-friendly error message. You can see this in the current version by not specifying the `adaptor` parameter. This change attempts to avoid such an error by not failing when crafting an exception error message.
pratikmallya
added
the
change/standard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When some of the options are incorrectly specified, jack will
throw an NPE when trying to craft a user-friendly error message.
You can see this in the current version by not specifying the
adaptorparameter.This change attempts to avoid such an error by not failing when
crafting an exception error message.