Don't Use WasmGC Instructions Just Yet #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point we had to switch away from `wasm-opt` automatically detecting the WebAssembly features, because they deprecated and turned that into a no-op. Since then we specified that it should just use all the features. This used to work all the time, but with the introduction of reference types it now started optimizing some of those instructions into instructions that are only available with the `WasmGC` proposal. This slipped through because Chrome and Firefox already support `WasmGC` but Safari does not... yet, because they also will start to support it very soon. In the meantime and also to ensure `wasm-opt` isn't ever going to sneak in any unwanted features, we now explicitly specify all the features that we want to use.
CryZe
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point we had to switch away from
wasm-optautomatically detecting the WebAssembly features, because they deprecated and turned that into a no-op. Since then we specified that it should just use all the features. This used to work all the time, but with the introduction of reference types it now started optimizing some of those instructions into instructions that are only available with theWasmGCproposal. This slipped through because Chrome and Firefox already supportWasmGCbut Safari does not... yet, because they also will start to support it very soon. In the meantime and also to ensurewasm-optisn't ever going to sneak in any unwanted features, we now explicitly specify all the features that we want to use.