ComboBox width #11
Closed
ComboBox width #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexKnauth
force-pushed
the
choice-width
branch
from
4408893
to
780894b
Compare
AlexKnauth
force-pushed
the
choice-width
branch
from
780894b
to
5261376
Compare
AlexKnauth
force-pushed
the
choice-width
branch
from
5261376
to
98235c6
Compare
AlexKnauth
force-pushed
the
choice-width
branch
from
98235c6
to
4f613b6
Compare
AlexKnauth
force-pushed
the
choice-width
branch
from
07790bf
to
28e50dd
Compare
|
Can you attach some screenshots of the situation before / after? |
|
When I first opened this PR last year, most of my choice options were line-wrapped onto multiple lines. I made this PR and started using it myself instead of master, so I hadn't noticed, the problem seems to be fixed now. I went to make a screenshot of "before" and it seems fine: I can close this PR now. Fixed in master by #18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the
ComboBoxwidth to be approximately the width of the 7/8ths-percentile option description. The goal is to have at least 7 out of every 8 option descriptions not have to be line-wrapped on average.I think this goes by bytes, not by chars or grapheme clusters, and certainly not by precise rendered width of anything, but if that kind of unicode weirdness only affects less than 1/8th of the option descriptions, I hope this is a good enough approximation.