Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to GitHub Actions #245

Merged
merged 2 commits into from
Sep 13, 2019
Merged

Switch to GitHub Actions #245

merged 2 commits into from
Sep 13, 2019

Conversation

CryZe
Copy link
Collaborator

@CryZe CryZe commented Sep 13, 2019

This commit switches our CI from Travis CI + AppVeyor to GitHub Actions. There's a few minor problems still such as the Windows runners sometimes not being able to checkout the commit or upload the artifacts. This seems to be mitigated by running the Windows jobs first though. Other problems include that the currently released version of cross isn't compatible with GitHub Actions so we use a custom version in the meantime.

This commit switches our CI from Travis CI + AppVeyor to GitHub Actions.
There's a few minor problems still such as the Windows runners
sometimes not being able to checkout the commit or upload the artifacts.
This seems to be mitigated by running the Windows jobs first though.
Other problems include that the currently released version of cross
isn't compatible with GitHub Actions so we use a custom version in the
meantime.
@CryZe CryZe added enhancement An improvement for livesplit-core. ci Affects the Continuous Integration. code quality Affects the quality of the code. labels Sep 13, 2019
@CryZe
Copy link
Collaborator Author

CryZe commented Sep 13, 2019

There's a couple of remaining issues with this:

  • Sometimes the network connection fails on the Windows jobs (checking out the commit or publishing a release). Issue
  • You can't restart individual jobs, only the whole thing. Issue
  • This uses a custom pre-release version of cross.
  • The 32-bit macOS build has been disabled. It doesn't seem to build. Supposedly 32-bit macOS is deprecated. Not sure if that's the problem though.
  • The asmjs build is disabled until the next cross version comes out.
  • FreeBSD is not supported anymore by cross.
  • crates.io doesn't support the GitHub Actions badge yet, there's a PR Support GitHub Actions Badges rust-lang/crates.io#1838

@CryZe CryZe merged commit 92808d6 into LiveSplit:master Sep 13, 2019
@CryZe CryZe added this to the v0.12 milestone Oct 14, 2019
@CryZe CryZe deleted the gh-actions branch November 16, 2021 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Affects the Continuous Integration. code quality Affects the quality of the code. enhancement An improvement for livesplit-core.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant