Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added get_path method to Run so the path can be actually accessed. #312

Merged
merged 2 commits into from
Mar 12, 2020
Merged

Added get_path method to Run so the path can be actually accessed. #312

merged 2 commits into from
Mar 12, 2020

Conversation

Ynscription
Copy link
Contributor

Aded a get_path method to Run so the path can be accessed for saving, as I asume it was intended to be.

The Run struct contains an Option to store the path to the save file it was loaded from.
This comes in really handy when saving, as the path can be simply read from the path.
However, the path attribute of Run was private and inaccessible in any way, making it unusable.

Now the path should be easily accessible.

Copy link
Collaborator

@CryZe CryZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also there's a formatting mismatch. Probably a tab or some weird whitespace.

src/run/mod.rs Outdated Show resolved Hide resolved
@CryZe CryZe added code quality Affects the quality of the code. enhancement An improvement for livesplit-core. labels Mar 12, 2020
@CryZe CryZe merged commit 1027a92 into LiveSplit:master Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Affects the quality of the code. enhancement An improvement for livesplit-core.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants